-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added experimental features flag #4679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please update the changelog and add a doc about feature flags. You can add this to different components. https://github.com/thanos-io/thanos/tree/main/docs/components
fbf6cc0
to
76c4a3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr looks good to me once the docs CI issue is fixed. @thanos-io/thanos-maintainers Does this experimental flags
design look good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits only, otherwise LGTM, thanks!
f85056e
to
85e930e
Compare
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
0918390
to
39ce8a2
Compare
c4de7b6
to
7459158
Compare
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
7459158
to
7d66615
Compare
a9d164d
to
e64440b
Compare
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
8ef9bae
to
098e6c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit, otherwise LGTM! Thanks 💪🏽
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
Running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, make docs
to be run
4399552
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
7052b0e
to
4fe49e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, i want to add the parameter but it denied to save which means the flag is illegal. I have no idea why, please help me. |
Signed-off-by: metonymic-smokey ahuja.aditi@gmail.com
Changes
Fixes #4022
This PR adds an
--enable-feature
flag toquery
, similar to Prom's--enable-features
flag.The features that can be currently turned on are enabling negative offset and @ modifier.
Verification