Interactive example does not work for MacOS

[metonymic-smokey]

Thanos, Prometheus and Golang version used: latest,2.29,1.16

Object Storage Provider:
Local filesystem

What happened:
The interactive example, examples/interactive/interactive_test.go does not run for MacOS users. The go test command results in an error.

What you expected to happen:
The example should run without an error and the UI should open in a browser when it runs.

How to reproduce it (as minimally and precisely as possible):
Run make docker. Then run go test interactive_test.go -test.timeout=9999m in examples/interactive.

Anything else we need to know:

[matej-g]

Hey @metonymic-smokey, would you mind posting what is the exact error you get?

AFAIK the interactive test has not been really tried on platforms other than Linux, but would be nice if we can make it work on MacOS as well.

[yeya24]

@matej-g The error I got locally:

❯ go test interactive_test.go -test.timeout=9999m
# github.com/containerd/cgroups
/Users/yeya24/go/pkg/mod/github.com/containerd/cgroups@v1.0.1/memory.go:463:14: undefined: unix.Eventfd
/Users/yeya24/go/pkg/mod/github.com/containerd/cgroups@v1.0.1/memory.go:463:30: undefined: unix.EFD_CLOEXEC
/Users/yeya24/go/pkg/mod/github.com/containerd/cgroups@v1.0.1/utils.go:70:8: undefined: unix.CGROUP2_SUPER_MAGIC
/Users/yeya24/go/pkg/mod/github.com/containerd/cgroups@v1.0.1/utils.go:77:18: undefined: unix.CGROUP2_SUPER_MAGIC
FAIL    command-line-arguments [build failed]
FAIL

[matej-g]

Hm it looks like we're hitting this containerd/cgroups#19. The package is used in e2emonitoring in efficientgo/e2e. We will probably need to find a way to solve this in the upstream.

In the meantime, perhaps we can have the tests without the monitoring endpoint, which would remove the dependency on e2emonitoring - which is nice-to-have but it is not essential for the interactive tests to run. WDYT?

[yeya24]

In the meantime, perhaps we can have the tests without the monitoring endpoint, which would remove the dependency on e2emonitoring - which is nice-to-have but it is not essential for the interactive tests to run. WDYT?

SGTM!

[matej-g]

If any MacOS user can confirm this works 🙂 - #4726

[metonymic-smokey]

I'll test this out tomorrow. Thanks!

…

On Fri, 1 Oct 2021, 21:42 Matej Gera, ***@***.***> wrote: If anyone MacOS user can confirm this works 🙂 - #4726 <#4726> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4642 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALV2I52C6SIOACQ24FJ2JJ3UEXMVNANCNFSM5DR3BDXA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[yeya24]

Close now as it is fixed.