Receiver: instrument multitsdb tenant series tracing tag correctly

[yeya24]

At https://github.com/thanos-io/thanos/blob/main/pkg/store/multitsdb.go#L274, a tenant tag is added. But it uses ClientAddContextTags method and that method is only used in gRPC method calls. In the case of tenant's local TSDB, there is no gRPC call anymore so the instrumentation doesn't work.

I expect to see https://github.com/thanos-io/thanos/blob/main/pkg/store/multitsdb.go#L172 get properly instrumented with the tenant tag.

Screenshot of the traces for tenant series call:

[wiardvanrij]

Added tag good first issue - even though this is somewhat deeper into the tech, I think with the comment from @yeya24 it should be a fun thing to pick up. Feel free to ask help if needed.

[metonymic-smokey]

From a quick look at the linked code references, I think adding a tag to the context here should fix it?

[yeya24]

From a quick look at the linked code references, I think adding a tag to the context here should fix it?

Yeah I think so, would you like to give it a try?

[metonymic-smokey]

I'll start working on it over the weekend.

…

On Sun, 9 Jan 2022, 21:19 Ben Ye, ***@***.***> wrote: From a quick look at the linked code references, I think adding a tag to the context here <https://github.com/thanos-io/thanos/blob/main/pkg/store/multitsdb.go#L172> should fix it? Yeah I think so, would you like to give it a try? — Reply to this email directly, view it on GitHub <#5002 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALV2I56N76STSYYTQ3ANOLTUVGVB3ANCNFSM5KY3NMAQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

[metonymic-smokey]

Opened a draft PR. Please let me know if I'm proceeding in the right direction. Many thanks!