store/s3: add possibility to get more information about the requests/responses #530
Comments
|
With the new objstore.config, you are more than welcome to add this option (: 👍 or anyone else can do it. |
|
Actually, |
|
Well, it might be ok to put it under feature flag, so you can start your component with this super verbose option only temporary while debugging. (: |
|
@GiedriusS hi did you start working on this? if not I am happy to do it. let me know |
|
or/and @bwplotka Do you know anybody who started working on this ? |
|
Not aware of any, so go for it! |
`minio.Client` has a `TraceOn` method which will be called when one set the `traceon: true` in the bucket config. This was a feature request here thanos-io#530
* add trace functionality to S3 client `minio.Client` has a `TraceOn` method which will be called when one set the `traceon: true` in the bucket config. This was a feature request here #530 * typo * make docs * change s3 trace configuration
|
Thank you a lot for your work on this, @szalai1! Closing as this exists now in form of |
* add trace functionality to S3 client `minio.Client` has a `TraceOn` method which will be called when one set the `traceon: true` in the bucket config. This was a feature request here thanos-io/thanos#530 * typo * make docs * change s3 trace configuration
It would be useful to be able to look at the requests themselves made by Thanos Store easily.
minio-gosupports a method calledTraceOn: https://github.com/minio/minio-go/blob/master/api.go#L347. If that is called on a client then each request and response is logged to aio.Writer. Perhaps this could be added behind a separate flag something like--s3.traceon. It could optionally take a string argument - a file where such logs would be written. Obviously, one can look at the requests made by Thanos Store by using external tools such astcpdumporstracebut IMHO it would be useful to have such functionality baked in Thanos Store to make it easier to debug problems.The text was updated successfully, but these errors were encountered: