-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics to PromQLShardingMiddleware #5606
Comments
Hi @idoqo, I checked that branch and the code looks good! For not shardable query you could try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Is your proposal related to a problem?
Now we don't have any instrumentation to the
PromQLShardingMiddleware
so we might miss some very important stats.I'd like to see metrics like Number of shardable queries and non-shardable queries.
Describe the solution you'd like
The implementation should be straightforward to add two counters to the middleware
The text was updated successfully, but these errors were encountered: