Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to PromQLShardingMiddleware #5606

Closed
yeya24 opened this issue Aug 18, 2022 · 2 comments · Fixed by #5650
Closed

Add metrics to PromQLShardingMiddleware #5606

yeya24 opened this issue Aug 18, 2022 · 2 comments · Fixed by #5650

Comments

@yeya24
Copy link
Contributor

yeya24 commented Aug 18, 2022

Is your proposal related to a problem?

Now we don't have any instrumentation to the PromQLShardingMiddleware so we might miss some very important stats.
I'd like to see metrics like Number of shardable queries and non-shardable queries.

Describe the solution you'd like

The implementation should be straightforward to add two counters to the middleware

@idoqo
Copy link
Contributor

idoqo commented Aug 24, 2022

Hi @yeya24, Trying to work on this here, but not sure how to try it out Can you help provide some sample non-shardable queries?

@yeya24
Copy link
Contributor Author

yeya24 commented Aug 24, 2022

here

Hi @idoqo, I checked that branch and the code looks good! For not shardable query you could try up and shardable query you could try sum(up) by (job). Let me know if this works for you or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants