Add sharded queries metrics #5650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoqo
force-pushed
the
sharded-query-metrics
branch
from
050f9ed
to
475db96
Compare
Signed-off-by: idoko <okokomichaels@outlook.com>
Signed-off-by: idoko <okokomichaels@outlook.com>
|
This is looking really good. I just wonder if we should make the result a label so that ration calculation can be easier. E.g |
|
Agree, let's make it shardable a label and keep one metric only |
Signed-off-by: idoko <okokomichaels@outlook.com>
Signed-off-by: idoko <okokomichaels@outlook.com>
|
We need another rebase. |
yeya24
requested changes
Aug 30, 2022
idoqo
force-pushed
the
sharded-query-metrics
branch
from
1345f91
to
2730fe6
Compare
Signed-off-by: idoko <okokomichaels@outlook.com>
yeya24
reviewed
Aug 30, 2022
Signed-off-by: idoko <okokomichaels@outlook.com>
prajain12
pushed a commit
to prajain12/thanos
that referenced
this pull request
Sep 6, 2022
* add query sharding metrics Signed-off-by: idoko <okokomichaels@outlook.com> * update changelog.md Signed-off-by: idoko <okokomichaels@outlook.com> * use CounterVec for sharding metrics Signed-off-by: idoko <okokomichaels@outlook.com> * revert to literal value Signed-off-by: idoko <okokomichaels@outlook.com> * move changes to unreleased Signed-off-by: idoko <okokomichaels@outlook.com> * fix PR number in changelog Signed-off-by: idoko <okokomichaels@outlook.com> Signed-off-by: idoko <okokomichaels@outlook.com> Signed-off-by: Prakul Jain <prakul.jain@udaan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds basic metrics to track the number of shardable and non-shardable queries processed by
PromQLShardingMiddleware.Fixes #5606
Changes
Verification
Newly added metrics show up in
http://<query-frontend-address>/metrics