Propagate retriable/haltable errors from compactor #1183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We observed thanos compactor was exiting on upload errors. Previously, a new
error was created from all worker errors so the custom type was not propagated.
This introduces
go-multierror
to preserve the error types.If all errors returned are retriable, it is safe to retry the compaction.
Since the compactor may still return a single error this logic is preserved.
(Happy to refactor out the duplicated logic with individual error checks.)
Verification
Tests are passing and I'll run this change with real workloads shortly.