Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecar: Added support for streaming, chunked remote read. #1268

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Jun 21, 2019

Fixes: #488

Signed-off-by: Bartek Plotka bwplotka@gmail.com

go.mod Outdated Show resolved Hide resolved
@bwplotka bwplotka force-pushed the v0.5.0-rr branch 5 times, most recently from ef5d17b to a460fa6 Compare August 20, 2019 12:23
@bwplotka bwplotka force-pushed the v0.5.0-rr branch 4 times, most recently from 431aaf5 to e57811c Compare August 22, 2019 10:31
Copy link
Contributor

@krasi-georgiev krasi-georgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point me to the test that ensure a good behavior when the x-streamed-protobuf returns multi frames?

pkg/store/prometheus.go Outdated Show resolved Hide resolved
pkg/store/prometheus.go Outdated Show resolved Hide resolved
pkg/store/prometheus.go Outdated Show resolved Hide resolved
pkg/store/prometheus.go Show resolved Hide resolved
pkg/store/prometheus.go Outdated Show resolved Hide resolved
pkg/store/prometheus.go Show resolved Hide resolved
pkg/store/prometheus.go Show resolved Hide resolved
@bwplotka bwplotka force-pushed the v0.5.0-rr branch 2 times, most recently from c216e97 to d7b4aef Compare August 27, 2019 08:50
@bwplotka
Copy link
Member Author

bwplotka commented Aug 27, 2019

@krasi-georgiev The merging multi series frame are tested in proxy code here: https://github.com/thanos-io/thanos/blob/master/pkg/store/proxy_test.go#L70

But adding more testcases.

@bwplotka
Copy link
Member Author

Started discussion on the StoreAPI Series API invariant aka multi series frame here: #1464

@bwplotka
Copy link
Member Author

Changed this accordingly to #1464 decision. CC @krasi-georgiev

Fixes: #488

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sidecar: Optimize Prometheus Remote Read API.
4 participants