unhide disable-downsampling flag in compactor #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
reviewed
Aug 8, 2019
yeya24
force-pushed
the
unhide-downsample
branch
from
8317a30
to
c8661ab
Compare
bwplotka
approved these changes
Aug 9, 2019
cmd/thanos/compact.go
Outdated
| @@ -99,10 +99,9 @@ func registerCompact(m map[string]setupFunc, app *kingpin.Application) { | |||
| generateMissingIndexCacheFiles := cmd.Flag("index.generate-missing-cache-file", "If enabled, on startup compactor runs an on-off job that scans all the blocks to find all blocks with missing index cache file. It generates those if needed and upload."). | |||
| Hidden().Default("false").Bool() | |||
|
|
|||
| // TODO(bplotka): Remove this flag once https://github.com/thanos-io/thanos/issues/297 is fixed. | |||
| disableDownsampling := cmd.Flag("debug.disable-downsampling", "Disables downsampling. This is not recommended "+ | |||
| disableDownsampling := cmd.Flag("disable-downsampling", "Disables downsampling. This is not recommended "+ | |||
There was a problem hiding this comment.
Can we name it downsampling.disable?
There was a problem hiding this comment.
Essentially we might want to have more downsampling options some day (:
cmd/thanos/compact.go
Outdated
| @@ -99,10 +99,9 @@ func registerCompact(m map[string]setupFunc, app *kingpin.Application) { | |||
| generateMissingIndexCacheFiles := cmd.Flag("index.generate-missing-cache-file", "If enabled, on startup compactor runs an on-off job that scans all the blocks to find all blocks with missing index cache file. It generates those if needed and upload."). | |||
| Hidden().Default("false").Bool() | |||
|
|
|||
| // TODO(bplotka): Remove this flag once https://github.com/thanos-io/thanos/issues/297 is fixed. | |||
| disableDownsampling := cmd.Flag("debug.disable-downsampling", "Disables downsampling. This is not recommended "+ | |||
| disableDownsampling := cmd.Flag("disable-downsampling", "Disables downsampling. This is not recommended "+ | |||
| "as querying long time ranges without non-downsampled data is not efficient and not useful (is not possible to render all for human eye)."). | |||
There was a problem hiding this comment.
Suggested change
| "as querying long time ranges without non-downsampled data is not efficient and not useful (is not possible to render all for human eye)."). | |
| "as querying long time ranges without non-downsampled data is not efficient and useful e.g it is not possible to render all samples for a human eye anyway"). |
yeya24
force-pushed
the
unhide-downsample
branch
from
c8661ab
to
8d9d78d
Compare
Signed-off-by: yeya24 <yb532204897@gmail.com>
yeya24
force-pushed
the
unhide-downsample
branch
from
8d9d78d
to
bdbab8f
Compare
|
Updated 😄 PTAL @bwplotka @GiedriusS |
bwplotka
approved these changes
Aug 9, 2019
|
Thank you! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yeya24 yb532204897@gmail.com
fix #1377
Do I have to remove the
debugprefix of this flag?Changes
Verification