Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/ui: Upgrade bootstrap typeahead to v4.0.2 #1409

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

brancz
Copy link
Member

@brancz brancz commented Aug 14, 2019

Changes

This PR updates bootstrap typeahead to v4.0.2

Verification

Tested that typeahead still works.

@bwplotka @povilasv @GiedriusS @domgreen

Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
@@ -7,8 +7,6 @@ TMP_GOPATH ?= /tmp/thanos-go
GOBIN ?= ${GOPATH}/bin
GO111MODULE ?= on
export GO111MODULE
GOPROXY ?= https://proxy.golang.org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing the proxy here? (:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise we have a failing build, the same reason why we had to update to a newer tsdb here: #1380

But I didn't want to update to a newer tsdb for a patch release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need that. It's also only for 0.6.1

@jojohappy
Copy link
Member

@brancz could this PR solve the issue #1271?

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bwplotka bwplotka merged commit 7d2b24b into thanos-io:release-0.6 Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants