Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: reduce code duplication #1440

Merged
merged 1 commit into from
Aug 27, 2019
Merged

cmd: reduce code duplication #1440

merged 1 commit into from
Aug 27, 2019

Conversation

zhulongcheng
Copy link
Contributor

@zhulongcheng zhulongcheng commented Aug 20, 2019 •
edited
Loading

Use block.DownloadMeta method to download block meta.

Reduce some duplication.

@zhulongcheng
cmd: replace Bucket.Get & json.Unmarshal with block.DownloadMeta
ba663ea 
Signed-off-by: zhulongcheng <zhulongcheng.dev@gmail.com>
@zhulongcheng zhulongcheng changed the title cmd: replace Bucket.Get & json.Unmarshal with block.DownloadMeta cmd: reduce code duplication Aug 22, 2019
bwplotka
bwplotka approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM and thanks (:

@bwplotka bwplotka merged commit 0a30a2e into thanos-io:master Aug 27, 2019
@zhulongcheng zhulongcheng deleted the use-DownloadMeta-method branch August 28, 2019 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhulongcheng @bwplotka