Choose lowest downsampling resolution with granular control. #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
commented
Aug 27, 2019
| }, | ||
| }, | ||
| { | ||
| query: "rate(up[5m:200s])", |
There was a problem hiding this comment.
This does not work as expected (in my mind). Step is still passed as 100 ms no matter what. cc @brian-brazil for help =D
There was a problem hiding this comment.
Based my knowledge on: https://prometheus.io/blog/2019/01/28/subquery-support/#subqueries
There was a problem hiding this comment.
The step is the one for query_range. We're not passing any hints relating to subqueries currently.
There was a problem hiding this comment.
Thanks! Will look deeper in PromQL if it's sane to actually propagate that hint & how.
34 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing with
Selectstorage.SelectParams.StepAs a follow up on this: #1431 I was experimenting with subquery + resolution in order to automatically adjust what downsampling Thanos should use. This, in theory, sounds great but looks like I don't really understand PromQL
storage.Params.Stepfield properly. Need to investigate more (is this param not propagated)?TODO:
[...:<resolution>]Signed-off-by: Bartek Plotka bwplotka@gmail.com