Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting TSDB block duration for receive service #1496

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Allow setting TSDB block duration for receive service #1496

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ede0620
Allow setting TSDB block duration
fhalim Sep 5, 2019
955a9a3
PR feedback: corrected flag naming, made the flag hidden by default
fhalim Sep 5, 2019
9ae912c
Enable WALCompression on Receive service
fhalim Sep 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cmd/thanos/receive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ func registerReceive(m map[string]setupFunc, app *kingpin.Application, name stri

replicationFactor := cmd.Flag("receive.replication-factor", "How many times to replicate incoming write requests.").Default("1").Uint64()

tsdbBlockDuration := modelDuration(cmd.Flag("tsdb.block-duration", "Duration for local TSDB blocks").Default("2h").Hidden())

m[name] = func(g *run.Group, logger log.Logger, reg *prometheus.Registry, tracer opentracing.Tracer, _ bool) error {
lset, err := parseFlagLabels(*labelStrs)
if err != nil {
Expand Down Expand Up @@ -106,6 +108,7 @@ func registerReceive(m map[string]setupFunc, app *kingpin.Application, name stri
*tenantHeader,
*replicaHeader,
*replicationFactor,
*tsdbBlockDuration,
)
}
}
Expand All @@ -130,15 +133,17 @@ func runReceive(
tenantHeader string,
replicaHeader string,
replicationFactor uint64,
tsdbBlockDuration model.Duration,
) error {
logger = log.With(logger, "component", "receive")
level.Warn(logger).Log("msg", "setting up receive; the Thanos receive component is EXPERIMENTAL, it may break significantly without notice")

tsdbCfg := &tsdb.Options{
RetentionDuration: retention,
NoLockfile: true,
MinBlockDuration: model.Duration(time.Hour * 2),
MaxBlockDuration: model.Duration(time.Hour * 2),
MinBlockDuration: tsdbBlockDuration,
MaxBlockDuration: tsdbBlockDuration,
WALCompression: true,
}

localStorage := &tsdb.ReadyStorage{}
Expand Down