Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compactor tests; Moved to full e2e compact test; Cleaned metrics. #1666

Merged
merged 5 commits into from
Oct 21, 2019

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Oct 18, 2019

PR is big but I recommend review commit by commit (:

Fixes: #1499
Fixes: #1661

cc @krasi-georgiev as I changed your tests (one was broken, some I moved to proper, full compact_e2e)

pkg/compact/compact.go Outdated Show resolved Hide resolved
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks right, just want to avoid confusions with the metrics.

@bwplotka
Copy link
Member Author

Thanks for looking into this metric "swap" @brancz - I am not 100% particularly sure if we won't confuse users, but I think what users was expecting seeing compactions_total was actually compactions that resulted in block (:

Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, some small questions and grammar suggestions (:

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pkg/compact/compact.go Outdated Show resolved Hide resolved
pkg/compact/compact.go Outdated Show resolved Hide resolved
pkg/compact/compact.go Outdated Show resolved Hide resolved
pkg/compact/compact.go Outdated Show resolved Hide resolved
pkg/objstore/inmem/inmem.go Outdated Show resolved Hide resolved
pkg/objstore/inmem/inmem.go Outdated Show resolved Hide resolved
pkg/objstore/inmem/inmem.go Outdated Show resolved Hide resolved
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Fixes: #1499

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Fixes: #1661

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌮

@bwplotka bwplotka merged commit 06bd4ee into master Oct 21, 2019
GiedriusS pushed a commit that referenced this pull request Oct 28, 2019
…s. (#1666)

* Fixed compactor tests; Moved to full e2e compact test; Cleaned metrics.

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>

* Removed block after each compaction group run.

Fixes: #1499

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>

* Moved to label hash for dir names for compactor groups.

Fixes: #1661

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>

* Addressed comments.

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>

* Addressed comments, rebased.

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compactor: weird directory structure Compactor: Compaction of Raw Data without cleaning local Disk
3 participants