Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

returns error messages when trigger reload with http #1848

Merged
merged 19 commits into from
Mar 4, 2020
Merged

returns error messages when trigger reload with http #1848

merged 19 commits into from
Mar 4, 2020

Commits on Feb 21, 2020

  1. returns error messages when trigger reload with http 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    7d8f413 View commit details
    Browse the repository at this point in the history

  2. use simple reloadRules function instead of magic chan error error 

    Signed-off-by: yapo.yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    3dea587 View commit details
    Browse the repository at this point in the history

  3. add tailing period for comment 

    Signed-off-by: yapo.yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    3ae2be2 View commit details
    Browse the repository at this point in the history

  4. fix comment 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    fef63bc View commit details
    Browse the repository at this point in the history

  5. add white space for better code reading 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    44f0e05 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2020

  1. collect thanos rule metrics into one struct 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    7324528 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2020

  1. remove termination logic and keep log only 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    1f6f3f5 View commit details
    Browse the repository at this point in the history

  2. update changelog for thanos-io#1848 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    9048e0c View commit details
    Browse the repository at this point in the history

  3. add tailing period 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    dbfca4e View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. check whether registry is nil 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    cd8d601 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Merge branch 'master' into master

    @00arthur00
    00arthur00 authored Feb 27, 2020
    Configuration menu
    Copy the full SHA
    e6f5d97 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. tailing period in metrics 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    084682f View commit details
    Browse the repository at this point in the history

  2. cancel with context 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    9583043 View commit details
    Browse the repository at this point in the history

  3. return ctx.Err() instead of errors.New 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    daca661 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2020

  1. register thanos rule metrics with promauto 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    6def413 View commit details
    Browse the repository at this point in the history

  2. return errs before set success related metrics 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    94a653a View commit details
    Browse the repository at this point in the history

  3. revert go.sum go.mod change 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    315e3c3 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. reload webhandler/sighup in one for loop 

    Signed-off-by: arthur yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    f397bed View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. reload with chan chan error 

    Signed-off-by: yapo.yang <yang_yapo@126.com>
    @00arthur00
    00arthur00 committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    56334f3 View commit details
    Browse the repository at this point in the history