Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump minio-go to v6.0.44 #1852

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

ribbybibby
Copy link
Contributor

This version includes minio/minio-go@d18cd1c, which adds functionality I would like to use with Thanos.

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

Is there something we can put in CHANGELOG for this? (: Fixed/improved something interesting for user? Looking by this contribution it has to be interesting ;p

@ribbybibby
Copy link
Contributor Author

Ha, I guess it depends on your definition of interesting.

This adds support for the environment variable AWS_CONTAINER_CREDENTIALS_FULL_URI which allows you to retrieve credentials from a generic local endpoint.

Signed-off-by: Rob Best <robertbest89@gmail.com>
@ribbybibby
Copy link
Contributor Author

Pushed an item to the CHANGELOG 👍

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a CHANGELOG item then (:

Thanks!

@ribbybibby
Copy link
Contributor Author

CHANGELOG'd

@bwplotka bwplotka merged commit 7426f1f into thanos-io:master Dec 9, 2019
@bwplotka
Copy link
Member

bwplotka commented Dec 9, 2019

Yup, seen, just waited on CI (: Thanks.

@ribbybibby ribbybibby deleted the minio-go-v6.0.44 branch December 9, 2019 17:02
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@george-angel
Copy link

Not enough horn touted I'm afraid.

This change allows Thanos to hot reload AWS credentials.

We are running Vault deployment and a side-car helper with our AWS applications. Side-car uses Kubernetes SA as identity and provision temporary AWS keys and exposes them over http on localhost.

Thanos is now able to consume that http endpoint and use the temporary credentials provisioned by the sidecar. These credentials can be rotated as often as you want, 15 minutes, etc. without any disruption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants