Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persist settings in query UI #1870

Merged
merged 1 commit into from
Jan 12, 2020
Merged

persist settings in query UI #1870

merged 1 commit into from
Jan 12, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 11, 2019

Signed-off-by: yeya24 yb532204897@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #1743

Verification

squat
squat approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one small nit

pkg/ui/templates/query_menu.html Outdated Show resolved Hide resolved
@yeya24 yeya24 changed the title persist settings in query UI WIP: persist settings in query UI Dec 11, 2019
@yeya24
persist option in query UI
13c3660 
Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24 yeya24 changed the title WIP: persist settings in query UI persist settings in query UI Dec 11, 2019
@stale
Copy link

stale bot commented Jan 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 11, 2020
GiedriusS
GiedriusS approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Sorry for the late response. The code looks clean and I tried it locally - works as expected.

@stale stale bot removed the stale label Jan 12, 2020
@GiedriusS GiedriusS added stale and removed stale labels Jan 12, 2020
@GiedriusS GiedriusS merged commit 46e5f45 into thanos-io:master Jan 12, 2020
@yeya24 yeya24 deleted the persist-websetting branch January 12, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query: UI doesn't persist Thanos-specific settings
3 participants
@yeya24 @GiedriusS @squat