fix bug: reloading rule files with empty group doesn't take effect

[00arthur00]

Signed-off-by: yapo.yang yang_yapo@126.com

reloading rule with empty group keep the orignal rules.
Steps to reproduce:

1. initialize rules with below yaml:

groups:
  - name: test-alert-group
    partial_response_strategy: "warn"
    interval: 2m
    rules:
      - alert: TestAlert
        expr: 1
        labels:
          key: value
        annotations:
          key: value

  - name: test-rule-group
    partial_response_strategy: "warn"
    interval: 2m
    rules:
      - record: test_metric
        expr: 1

2. change yaml to empty group:

groups: []

3. run http reload

curl -X POST http://127.0.0.1:10902/-/reload

4. view rules in browser, thanos keeps the initial one instead of emty rule.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[00arthur00]

Any update?

[00arthur00]

@bwplotka ping

[simonpasquier]

FWIW this is fixing the same issue than #1439.

[00arthur00]

FWIW this is fixing the same issue than #1439
#1439 doesn't fix the issue I metioned. I verified commit 9b17ba1 just now.

@simonpasquier

[simonpasquier]

@00arthur00 The PR I linked (#1439) isn't merged yet so if you've tested with master, yes the bug is still there.

[00arthur00]

@00arthur00 The PR I linked (#1439) isn't merged yet so if you've tested with master, yes the bug is still there.

@simonpasquier Thanks. Since the issue is being fixed. I will close the issue.