Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecar: allow custom http con pool size fix #1953 #1969

Conversation

blockloop
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Allow custom connection pool size for Thanos sidecar to prevent excessive tcp connections on machines with very high load. More details are laid out in #1953

Verification

A build from my fork is currently running in production on our machines and handling ~1700 RPS with very little connection cycling.

$ netstat -a | awk '{ print $6 }' | grep -P '[A-Z]' | sort | uniq -c | sort -r
    951 ESTABLISHED
    166 TIME_WAIT
    146 CONNECTED
    133 CLOSE_WAIT
    129 FIN_WAIT2
     53 STREAM
     12 LISTEN
      4 FIN_WAIT1
      1 SEQPACKET
      1 I-Node
      1 Foreign

Other Info

HTTP connections

image

Signed-off-by: Brett Jones <blockloop@users.noreply.github.com>
@blockloop blockloop force-pushed the bjones/sidecar/allow-custom-connection-pool branch from c7f2746 to 41a42d8 Compare January 8, 2020 19:58
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@squat squat merged commit 8dbfe3d into thanos-io:master Jan 8, 2020
@blockloop blockloop deleted the bjones/sidecar/allow-custom-connection-pool branch July 2, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants