testutil: Moving all e2e utils to separate package, added TB union. #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
testutils
branch
3 times, most recently
from
14a8415
to
da4090d
Compare
kakkoyun
approved these changes
Jan 29, 2020
cmd/thanos/main_test.go
Outdated
| @@ -11,6 +11,7 @@ import ( | |||
| "path/filepath" | |||
|
|
|||
| "github.com/thanos-io/thanos/pkg/block/metadata" | |||
| "github.com/thanos-io/thanos/pkg/testutil/e2eutil" | |||
There was a problem hiding this comment.
nit: Shall we group the imports? Does it even matter for the tests?
There was a problem hiding this comment.
we should but we don't have tools for that so it's tedious and I am lazy (:
@jojohappy if you were asking if still valid: #984
pkg/testutil/testorbench.go
Outdated
| } | ||
|
|
||
| func (tb *UnionTB) IsBenchmark() bool { | ||
| if _, ok := tb.TB.(*testing.B); ok { |
There was a problem hiding this comment.
I'm totally NOT sure if this makes it easier to read or not, but the following could also be used
Suggested change
| if _, ok := tb.TB.(*testing.B); ok { | |
| _, ok := tb.TB.(*testing.B) | |
| return ok |
GiedriusS
reviewed
Jan 29, 2020
pkg/testutil/testorbench.go
Outdated
| func (tb *UnionTB) ResetTimer() { | ||
| if b, ok := tb.TB.(*testing.B); ok { | ||
| b.ResetTimer() | ||
| return |
There was a problem hiding this comment.
very minor nit: not needed return :P
jojohappy
approved these changes
Jan 30, 2020
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com