Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruler: Fix #2204 bug where alert queue is unpoppable causing full queue and dropped alerts #2238

Merged
merged 5 commits into from
Mar 9, 2020
Merged

ruler: Fix #2204 bug where alert queue is unpoppable causing full queue and dropped alerts #2238

merged 5 commits into from
Mar 9, 2020

Commits on Mar 9, 2020

  1. Add test for alert queue Pop after multiple Push 

    Signed-off-by: Robin Clarke-Williams <43950815+robincw-gr@users.noreply.github.com>
    @robincw-gr
    robincw-gr committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    fc12ef4 View commit details
    Browse the repository at this point in the history

  2. Fix alert queue bug by resignal after Pop (#2204) 

    Signed-off-by: Robin Clarke-Williams <43950815+robincw-gr@users.noreply.github.com>
    @robincw-gr
    robincw-gr committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    f87b9a1 View commit details
    Browse the repository at this point in the history

  3. Fix alert queue test and simplify 

    Signed-off-by: Robin Clarke-Williams <43950815+robincw-gr@users.noreply.github.com>
    @robincw-gr
    robincw-gr committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    07285c4 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md 

    Signed-off-by: Robin Clarke-Williams <43950815+robincw-gr@users.noreply.github.com>
    @robincw-gr
    robincw-gr committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    a745679 View commit details
    Browse the repository at this point in the history

  5. Link to thanos-io/thanos PR in CHANGELOG.md 

    Signed-off-by: Robin Clarke-Williams <43950815+robincw-gr@users.noreply.github.com>
    @robincw-gr
    robincw-gr authored Mar 9, 2020
    Configuration menu
    Copy the full SHA
    3b0056c View commit details
    Browse the repository at this point in the history