compact: Added overlap check before and after compact. Added extra index check for outsiders. #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
changed the title
bwplotka
changed the title
fabxc
reviewed
Apr 9, 2018
cmd/thanos/main.go
Outdated
| case <-c: | ||
| return nil | ||
| case s:= <-c: | ||
| return errors.Errorf("caught %s signal. Exiting.", s.String()) |
There was a problem hiding this comment.
Won't this make our run* functions return an error and make the program overall exit with 1? Seems like that's not what we want.
There was a problem hiding this comment.
mhm, yea, let's println or log here instead
bwplotka
commented
Apr 9, 2018
pkg/compact/compact.go
Outdated
| metas = append(metas, m.BlockMeta) | ||
|
|
||
| for _, s := range m.Compaction.Sources { | ||
| exclude[s] = struct{}{} |
There was a problem hiding this comment.
this is not enough. Still we have blocks that are "within" newBlock but are not in new Block sources ): this is kind of confusing -> we have only leafs there, right?
Signed-off-by: Bartek Plotka <bwplotka@gmail.com> compact: Move overlaps to compact function. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> compact: Added checks after compaction too. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> compact: Added missed output block meta. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> compact: Fixed overlapping check. Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
changed the title
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
fabxc
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartek Plotka bwplotka@gmail.com