Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: Update Prometheus mod to pull in prometheus/prometheus#7414 #2787

Merged
merged 1 commit into from
Jun 19, 2020
Merged

go.mod: Update Prometheus mod to pull in prometheus/prometheus#7414 #2787

merged 1 commit into from
Jun 19, 2020

Conversation

brancz
Copy link
Member

@brancz brancz commented Jun 19, 2020 •
edited
Loading

Signed-off-by: Frederic Branczyk fbranczyk@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Update Prometheus mod to pull in prometheus/prometheus#7414

Verification

Passing tests.

@brancz
go.mod: Update Prometheus mod to pull in prometheus/prometheus#7414
3ca9e73 
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
pracucci
pracucci approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This reminded we should do the same in Cortex.

squat
squat approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :)

@brancz brancz merged commit 02ab6b8 into thanos-io:master Jun 19, 2020
@brancz brancz deleted the update-prom branch June 19, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brancz @pracucci @squat