Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: Fix alert about unhealthy sidecar #2929

Merged
merged 1 commit into from
Aug 12, 2020

Commits on Aug 12, 2020

  1. mixin: Fix alert about unhealthy sidecar

    The alert was giving the wrong information as the $value contained
    the number of pods that failing to send heartbeat instead of the actual
    number of seconds that each sidecar was being unhealthy.
    
    Also the 5 minute interval is probably too low as on large deployments
    prometheus could take much longer to come up online and for sidecar to
    become actually useful.
    
    As such, we can simply subtract the timestamp of the last heartbeat from
    the current time and fire if we are lagging for more than 10 minutes.
    
    Signed-off-by: Markos Chandras <markos@chandras.me>
    hwoarang committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    c3bdfbf View commit details
    Browse the repository at this point in the history