Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReplicaLabelRemover panic when replicaLabels are not specified #2936

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Fix ReplicaLabelRemover panic when replicaLabels are not specified #2936

merged 1 commit into from
Jul 27, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jul 24, 2020 •
edited
Loading

Signed-off-by: Ben Ye yb532204897@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #2930

Verification

@yeya24
fix ReplicaLabelRemover panic when replicaLabels are not specified
7f4d7e9 
Signed-off-by: Ben Ye <yb532204897@gmail.com>
bwplotka
bwplotka approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a good fix, and thanks for it, but I think long term we might want to have different creation of those chained filters for different configurations instead of silently ignoring those.

Let's fix this for now though! (:

@bwplotka bwplotka merged commit 02672f3 into thanos-io:master Jul 27, 2020
@yeya24 yeya24 deleted the fix-replicalabel-panic branch August 7, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compact Panic: Won't run compaction - versions 0.13.0 & 0.14.0
2 participants
@yeya24 @bwplotka