Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching large chunks #2956

Merged
merged 8 commits into from
Jul 30, 2020
Merged

Fetching large chunks #2956

merged 8 commits into from
Jul 30, 2020

Commits on Jul 29, 2020

  1. Added unit test showing issue with large chunk in the block. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    a400ef3 View commit details
    Browse the repository at this point in the history

  2. Make sure that large chunk is indeed created. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    a6ee935 View commit details
    Browse the repository at this point in the history

  3. If chunk is not fully fetched, fetch remaining data. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    170fdc4 View commit details
    Browse the repository at this point in the history

  4. Added CHANGELOG.md entry. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    4e46562 View commit details
    Browse the repository at this point in the history

  5. Removed extra err parameter. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    9f89733 View commit details
    Browse the repository at this point in the history

  6. Removed extra t. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    444734c View commit details
    Browse the repository at this point in the history

  7. Removed extra tb. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    64a1cb4 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Reorder bucketChunkReader to show which fields mutex protects. 

    Also document mutex usage.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    f690af7 View commit details
    Browse the repository at this point in the history