Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply error in loop should not kill the sidecar #2996

Merged
merged 4 commits into from
Aug 7, 2020
Merged

Apply error in loop should not kill the sidecar #2996

merged 4 commits into from
Aug 7, 2020

Commits on Aug 7, 2020

  1. Log prometheus config reload error instead of stopping sidecar 

    Signed-off-by: Max Neverov <neverov.max@gmail.com>
    @mneverov
    mneverov committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    f2f0a33 View commit details
    Browse the repository at this point in the history

  2. Add reloader option; new flags to control reloader time intervals 

    Signed-off-by: Max Neverov <neverov.max@gmail.com>
    @mneverov
    mneverov committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    619b2cf View commit details
    Browse the repository at this point in the history

  3. Fix documentation after changes 

    Signed-off-by: Max Neverov <neverov.max@gmail.com>
    @mneverov
    mneverov committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    ad53a26 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from PR review 

    Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Max Neverov <neverov.max@gmail.com>
    @mneverov @bwplotka
    mneverov and bwplotka committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    f766970 View commit details
    Browse the repository at this point in the history