-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Go 1.15 #3022
Upgrade to Go 1.15 #3022
Conversation
ea7777b
to
2223c64
Compare
2223c64
to
b47dbb3
Compare
Somehow Netlify builds use Go and jobs fail. I couldn't figure where it's specified. |
Found the reason of Netlify failures https://github.com/netlify/build-image/blob/450c24b893036c2813a0b0d0a2a05bcdd81935a4/run-build-functions.sh |
# Ignore minikube setup working dirs. | ||
kube/bin | ||
kube/.kube | ||
kube/.minikube |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use Kubernetes in our tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have copied those from .gitignore
. I haven't checked them to be honest.
There's a failing test. I need to check the underlying cause.
|
@kakkoyun Reported here #3084. I am checking that now. Please ignore this first. |
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
cb4450a
to
2d42d40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM!
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
https://golang.org/doc/go1.15#compiler
1.14.7
1.15.0
Changes
promu
versionVerification
make build
make test-local