Correctly handle auto downsampling in codec #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <yb532204897@gmail.com>
bwplotka
reviewed
Aug 25, 2020
pkg/queryfrontend/cache_splitter.go
Outdated
|
|
||
| // TODO(yeya24): Add other request params as request key. | ||
| // GenerateCacheKey generates a cache key based on the Request and interval. | ||
| func (t constSplitter) GenerateCacheKey(_ string, r queryrange.Request) string { | ||
| currentInterval := r.GetStart() / time.Duration(t).Milliseconds() | ||
| func (t thanosCacheSplitter) GenerateCacheKey(_ string, r queryrange.Request) string { |
There was a problem hiding this comment.
It's not splitter anymore, rather cacheKeyGenerator ? (:
| for _, tc := range []struct { | ||
| name string | ||
| req queryrange.Request | ||
| expectedCacheKey string |
There was a problem hiding this comment.
Suggested change
| expectedCacheKey string | |
| expected string |
pkg/queryfrontend/roundtrip_test.go
Outdated
| @@ -300,6 +300,16 @@ func TestRoundTripCacheMiddleware(t *testing.T) { | |||
| MaxSourceResolution: 10 * seconds, | |||
| } | |||
|
|
|||
| // same query params as testRequest, different maxSourceResolution | |||
There was a problem hiding this comment.
Can we start comments with upper case letter like normal sentence?
pkg/queryfrontend/roundtrip_test.go
Outdated
| name: "do it again", | ||
| req: testRequest2, | ||
| name: "different max source resolution and different level", | ||
| req: testRequest4, |
There was a problem hiding this comment.
why not inlining those requests maybe?
Signed-off-by: Ben Ye <yb532204897@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye yb532204897@gmail.com
Changes
max_source_resolution=autocorrectly.Verification