Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: fixed linking issue for v016 docs on website #3256

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

thisisobate
Copy link
Contributor

@thisisobate thisisobate commented Sep 29, 2020

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

fixed linking issue for v016 docs on website.

@thisisobate thisisobate changed the title v0.16 link fix add aliases to tip for redirects Sep 29, 2020
@thisisobate thisisobate changed the title add aliases to tip for redirects added aliases to tip frontmatter for redirects Sep 29, 2020
@thisisobate
Copy link
Contributor Author

PTAL: @bwplotka @squat @prmsrswt

@squat
Copy link
Member

squat commented Sep 29, 2020

Is this a dupe of #3258? Do we need this in the 0.15 docs too? Maybe we can rather merge this into the release branch. and then merge the release branch into master as part of our regular release flow

@thisisobate
Copy link
Contributor Author

thisisobate commented Sep 29, 2020

This is beneficial for only future releases. #3258 was made specifically for release-0.16 docs because it has already been cut from master so aliases frontmatter settings can't be found in release-0.16 docs. @squat

@thisisobate
Copy link
Contributor Author

I think we should consider merging #3258 to master before we could consider this PR since #3258 promises to solve the problem at hand.

Also, couldn't view netlify preview in checks so I don't know if it's right to merge #3258

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bit tedious. What's wrong with the approach on hugo.yaml?

@thisisobate
Copy link
Contributor Author

thisisobate commented Sep 29, 2020

I tried the approach on hugo.yaml but it wasn't working.

This was what I did:

v0.16: "/:section /:filename.md" 

yt? @bwplotka

Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
@thisisobate thisisobate changed the title added aliases to tip frontmatter for redirects Website: fixed linking issue for v016 docs on website Oct 2, 2020
@bwplotka
Copy link
Member

bwplotka commented Oct 2, 2020

This is it! Good for quick short term fix 👍

@bwplotka bwplotka merged commit bb1662a into thanos-io:master Oct 2, 2020
@thisisobate thisisobate deleted the v016-docs-fix branch October 2, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants