Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objstore/azure: Disable Azure blob exception logging #3331

Merged
merged 1 commit into from
Oct 19, 2020
Merged

objstore/azure: Disable Azure blob exception logging #3331

merged 1 commit into from
Oct 19, 2020

Commits on Oct 18, 2020

  1. Disable Azure blob exception logging

    Ever since the introduction of the deletion marker, Thanos compact has
    been filling the logs with Azure blob storage exceptions. As discussed
    in #2565, the error logging should be handled by Thanos itself, so this
    patch turns off standard logging from the Azure library.
    
    However, [due to the way logging is set up in the library][1], it will
    always log errors to syslog, regardless of how `ShouldLog` is
    configured. As such, and until that can be a configurable behavior, care
    should be taken to handle that from the syslog side as well.
    
    [1]: https://github.com/Azure/azure-storage-blob-go/blob/48358e1de5110852097ebbc11c53581d64d47300/azblob/zc_policy_request_log.go#L100-L102
    
    Signed-off-by: Pedro Araujo <phcrva@gmail.com>
    pharaujo committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    fb8d81d View commit details
    Browse the repository at this point in the history