-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mixin: Add block deletion panels for compactor dashboard #3380
mixin: Add block deletion panels for compactor dashboard #3380
Conversation
8a9ec2d
to
df18581
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I can see the use case.
Let's wait for the renaming PR to be merged.
df18581
to
0dba1bb
Compare
Renaming PRs should be merged. |
0dba1bb
to
c4865da
Compare
Updated for new names 👌 |
@Sayrus Looks good so far. You need to run |
Signed-off-by: Mathis Raguin <mathis@cri.epita.fr>
c4865da
to
aed289d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Let's be super clear on what we actually add in the changelog.
Then we can merge.
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
2d53172
to
044241f
Compare
Changes
This PR adds a new row to the Thanos Compact Dashboard. This row contains:
Verification
Our compactor isn't deleting anything at the moment so the graphs are empty.
Notes
Metrics will need to be renamed following #3309 as they use the
thanos_compact_*
format.