compact: Added index size limiting planner detecting output index size over 64GB. #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
index-size-planner
branch
from
99f0ee5
to
177d3c8
Compare
yeya24
approved these changes
Nov 5, 2020
|
Addressed all (: |
bwplotka
force-pushed
the
index-size-planner
branch
from
e62a66a
to
9ac6426
Compare
…e over 64GB. Fixes: #1424 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
index-size-planner
branch
from
9ac6426
to
648f635
Compare
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
index-size-planner
branch
2 times, most recently
from
e5b5d64
to
3bbf7b0
Compare
|
I need to fix some e2e tests (actually extend them to test index size limiting) |
bwplotka
force-pushed
the
index-size-planner
branch
from
3bbf7b0
to
a12766d
Compare
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
index-size-planner
branch
from
a12766d
to
3264ee7
Compare
|
Should be fixed! |
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
…e over 64GB. (thanos-io#3410) * compact: Added index size limiting planner detecting output index size over 64GB. Fixes: thanos-io#1424 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Addressed comments; added changelog. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Skipped flaky test. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chained with #3409
Fixes: #1424
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com