Upgrade Cortex into Thanos #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
yeya24
approved these changes
Nov 11, 2020
Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
There is a new supported config in the limits middleware https://github.com/cortexproject/cortex/blob/master/pkg/querier/queryrange/limits.go#L61. I think it is useful and we should support it. I will open a feature request to track this. |
bwplotka
approved these changes
Nov 11, 2020
@yeya24 Sure. Just pay attention this applies only to range queries. It should work in conjunction with the same limit applied in the querier, and not just in the query-frontend. |
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
* Upgrade Cortex into Thanos Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed unused CortexFrontendConfig Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We recently refactored the query-frontend in Cortex, in order to introduce the support for a new component (query-scheduler used by query-frontend v2). The "old" query-frontend logic (v1) has been left untouched, a part from some package refactoring. Also the v1 doesn't handle the downstream, slow query logging and response compression anymore, but they're available as pluggable middlewares.
In this PR I've upgraded Cortex and done the required changes 🤞
Note: this upgrade has the nice side effect that Thanos will not vendor anymore Cortex
pkg/storegateway, thus unblocking the PR #3431.Verification
Existing tests.