Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting changes for changelog #3458

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Linting changes for changelog #3458

merged 1 commit into from
Nov 18, 2020

Conversation

yashrsharma44
Copy link
Contributor

I made some changes for the changelog regarding the linting of it. I think, we don't have any lint checks for markdown, so this might be a good idea to add one.

Signed-off-by: Yash Sharma yashrsharma44@gmail.com

Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

What linter you used? (: That's the plan to have one, yes at some point.

Ideally in https://github.com/bwplotka/mdox

@bwplotka bwplotka merged commit 028bde4 into thanos-io:master Nov 18, 2020
Oghenebrume50 pushed a commit to Oghenebrume50/thanos that referenced this pull request Dec 7, 2020
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants