Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query: Added PromQL tests framework supporing multiple stores. First step towars Query pushdown! #3631

Merged
merged 2 commits into from
Dec 19, 2020

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Dec 16, 2020

TDD all the way!

Related to #305

Changes

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

@bwplotka
Copy link
Member Author

Depends on prometheus/prometheus#8300

@bwplotka
Copy link
Member Author

bwplotka commented Dec 16, 2020

Direction is to use promtool unittest, so closing prometheus/prometheus#8300

Will adjust test sometime, so copied all framework for now.

@bwplotka bwplotka force-pushed the query-pushdown branch 3 times, most recently from cf4d4b4 to 81af0bd Compare December 18, 2020 13:26
@bwplotka bwplotka force-pushed the query-pushdown branch 2 times, most recently from 424d5ca to 9b06d6e Compare December 18, 2020 14:48
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka
Copy link
Member Author

This should be rdy for review 🤗

Copy link
Member Author

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: No need to review *.test files. Those are copied from Prometheus.

@@ -0,0 +1,499 @@
load 5m
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to review this, it's 1:1 copied from Prometheus.

@@ -0,0 +1,22 @@

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to review this, it's 1:1 copied from Prometheus.

@@ -0,0 +1,892 @@
# Testdata for resets() and changes().
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to review this, it's 1:1 copied from Prometheus.

@@ -0,0 +1,193 @@
# Two histograms with 4 buckets each (x_sum and x_count not included,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to review this, it's 1:1 copied from Prometheus.

@@ -0,0 +1,59 @@
eval instant at 50m 12.34e6
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to review this, it's 1:1 copied from Prometheus.

@@ -0,0 +1,469 @@
load 5m
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to review this, it's 1:1 copied from Prometheus.

@@ -0,0 +1,201 @@
load 10s
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to review this, it's 1:1 copied from Prometheus.

@@ -0,0 +1,51 @@
load 10s
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to review this, it's 1:1 copied from Prometheus.

@@ -0,0 +1,117 @@
load 10s
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to review this, it's 1:1 copied from Prometheus.

@@ -0,0 +1,218 @@
store {} 0 30m
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 1:1 copied from Prometheus, except beginning where we load multiple stores.

* Improved logging.
* Improved debug matching info.
* Fixed important matching bug.
* Found reset bug, added issue #3644 and commented code.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇 Amazing work.

@kakkoyun kakkoyun merged commit 202fb4d into master Dec 19, 2020
@bwplotka
Copy link
Member Author

Can't believe it was merged so fast! Thanks ❤️

@bwplotka bwplotka deleted the query-pushdown branch December 19, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants