-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query: Added PromQL tests framework supporing multiple stores. First step towars Query pushdown! #3631
Conversation
Depends on prometheus/prometheus#8300 |
Direction is to use promtool unittest, so closing prometheus/prometheus#8300 Will adjust test sometime, so copied all framework for now. |
cf4d4b4
to
81af0bd
Compare
424d5ca
to
9b06d6e
Compare
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
9b06d6e
to
9b86020
Compare
This should be rdy for review 🤗 |
9b86020
to
ac30f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: No need to review *.test
files. Those are copied from Prometheus.
@@ -0,0 +1,499 @@ | |||
load 5m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to review this, it's 1:1 copied from Prometheus.
@@ -0,0 +1,22 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to review this, it's 1:1 copied from Prometheus.
@@ -0,0 +1,892 @@ | |||
# Testdata for resets() and changes(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to review this, it's 1:1 copied from Prometheus.
@@ -0,0 +1,193 @@ | |||
# Two histograms with 4 buckets each (x_sum and x_count not included, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to review this, it's 1:1 copied from Prometheus.
@@ -0,0 +1,59 @@ | |||
eval instant at 50m 12.34e6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to review this, it's 1:1 copied from Prometheus.
@@ -0,0 +1,469 @@ | |||
load 5m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to review this, it's 1:1 copied from Prometheus.
@@ -0,0 +1,201 @@ | |||
load 10s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to review this, it's 1:1 copied from Prometheus.
@@ -0,0 +1,51 @@ | |||
load 10s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to review this, it's 1:1 copied from Prometheus.
@@ -0,0 +1,117 @@ | |||
load 10s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to review this, it's 1:1 copied from Prometheus.
@@ -0,0 +1,218 @@ | |||
store {} 0 30m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's 1:1 copied from Prometheus, except beginning where we load multiple stores.
ac30f44
to
6178444
Compare
* Improved logging. * Improved debug matching info. * Fixed important matching bug. * Found reset bug, added issue #3644 and commented code. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
6178444
to
0d96950
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇 Amazing work.
Can't believe it was merged so fast! Thanks ❤️ |
TDD all the way!
Related to #305
Changes
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com