Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query-frontend: use detailed text description for cmd #3655

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Query-frontend: use detailed text description for cmd #3655

merged 1 commit into from
Jan 11, 2021

Conversation

MalloZup
Copy link
Contributor

@MalloZup MalloZup commented Dec 19, 2020 •
edited
Loading

Description:

this is a minor PR fix I just fund out when doing some exploratory usage of thanos.

The text is copied from upstream documentation, feel free to suggest changes if you think it could be improved. 🍶

Changes

  • add more text description for the command

Verification:

Before:

  query-frontend [<flags>]
    query frontend

After:

  query-frontend [<flags>]
    query frontend command implements a service that can be put in front of Thanos Queriers to improve the read path. It is based on the Cortex Query Frontend component so you can find some common features like Splitting and Results
    Caching. Query Frontend is fully stateless and horizontally scalable.

@MalloZup MalloZup changed the title Query-frontend CMD: use detailed text description Query-frontend: use detailed text description for cmd Dec 19, 2020
@MalloZup MalloZup force-pushed the query-frontend-pkg branch 4 times, most recently from 021841c to bf63864 Compare December 21, 2020 11:26
@MalloZup
Copy link
Contributor Author

@bwplotka or @yeya24 once you have 1 sec would be awesome if yuo just review it.. because I fear I will forget about this.. 😁 happy new year

yeya24
yeya24 reviewed Jan 4, 2021
View reviewed changes
cmd/thanos/query_frontend.go Outdated Show resolved Hide resolved
@MalloZup
Copy link
Contributor Author

@bwplotka thx.. will rebase

yeya24
yeya24 reviewed Jan 11, 2021
View reviewed changes
cmd/thanos/query_frontend.go Outdated Show resolved Hide resolved
docs/components/query-frontend.md Outdated
@@ -119,7 +119,9 @@ Naming is hard :) Please check [here](https://github.com/thanos-io/thanos/pull/2
```$
usage: thanos query-frontend [<flags>]

query frontend
query frontend command implements a service deployed in front of queriers to
improve query parallelisation and cachingQuery Frontend is fully stateless and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@MalloZup @bwplotka
Query-frontend CMD: use detailed text description
0e8a8ac 
Signed-off-by: dmaiocchi <sodar@riseup.net>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
yeya24
yeya24 approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Will merge on green.

@yeya24 yeya24 merged commit b93df83 into thanos-io:master Jan 11, 2021
@MalloZup
Copy link
Contributor Author

MalloZup commented Jan 11, 2021 •
edited
Loading

thx @yeya24 for feedback 🌞 \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

@bwplotka bwplotka Awaiting requested review from bwplotka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MalloZup @bwplotka @yeya24