Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Go version to 1.16 #3827

Merged
merged 8 commits into from
Apr 8, 2021
Merged

Upgrade Go version to 1.16 #3827

merged 8 commits into from
Apr 8, 2021

Conversation

longngn
Copy link
Contributor

@longngn longngn commented Feb 23, 2021 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Upgrade Go version to 1.16

Verification

  • Build and CI should be successful

@bwplotka
Copy link
Member

Let's do this for 0.20 release, there are lot's of performance unknowns in 1.16

Base automatically changed from master to main February 26, 2021 16:31
kakkoyun
kakkoyun requested changes Mar 11, 2021
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing it. Now that prom/golang-builder upgraded and master is open for 0.20 we can merged this. Could you please rebase and address review comments?

go.mod Outdated Show resolved Hide resolved
@longngn
Copy link
Contributor Author

longngn commented Mar 15, 2021

Looks good. Thanks for doing it. Now that prom/golang-builder upgraded and master is open for 0.20 we can merged this. Could you please rebase and address review comments?

Thanks, I'll do it asap

bwplotka
bwplotka previously approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are ready! I would love to merge this and compare the performance 🤗

Do you mind doing rebase? LGTM and thank you! 🙇🏽

@longngn
Upgrade Go version to 1.16
4b7cffe 
Signed-off-by: Nguyen Le Vu Long <vulongvn98@gmail.com>
@longngn
Run make deps
6e1bc2d 
Signed-off-by: Nguyen Le Vu Long <vulongvn98@gmail.com>
@longngn
Update change log
c9c87c9 
Signed-off-by: Nguyen Le Vu Long <vulongvn98@gmail.com>
@longngn
fix: revert go version in go.mod to 1.15
bca9b7d 
Signed-off-by: Nguyen Le Vu Long <vulongvn98@gmail.com>
@longngn
fix: run make deps (again)
cfdea00 
Signed-off-by: Nguyen Le Vu Long <vulongvn98@gmail.com>
@longngn
Run make deps again
6ea7223 
Signed-off-by: Nguyen Le Vu Long <vulongvn98@gmail.com>
@longngn
Copy link
Contributor Author

longngn commented Apr 2, 2021

I think we are ready! I would love to merge this and compare the performance 🤗

Do you mind doing rebase? LGTM and thank you! 🙇🏽

Done, thank you 😆

@longngn
Fix CHANGLOG.md format
dd2a72c 
Signed-off-by: Nguyen Le Vu Long <vulongvn98@gmail.com>
@GiedriusS
Merge branch 'main' into HEAD
6b75f3c 
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
@GiedriusS
Copy link
Member

The comment by @kakkoyun has been addressed. Merging this to upgrade to 1.16 for 0.20 🤗 thank you for your contribution!

@GiedriusS GiedriusS merged commit 67f906e into thanos-io:main Apr 8, 2021
@bwplotka
Copy link
Member

bwplotka commented Apr 9, 2021

Amazing, thanks! 🎉

@longngn longngn deleted the go-1.16 branch April 9, 2021 11:15
@longngn
Copy link
Contributor Author

longngn commented Apr 9, 2021

Thanks, this is my first merged PR for Thanos 🥳
And now I can continue working on #3816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun requested changes

@GiedriusS GiedriusS GiedriusS approved these changes

@bwplotka bwplotka bwplotka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@longngn @bwplotka @GiedriusS @kakkoyun