Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces errutil with tools/pkg/merrors; Fixes very ugly misuse of multi-error #3833

Closed
wants to merge 1 commit into from

Commits on Feb 26, 2021

  1. Replaces errutil with tools/pkg/merrors; Fixes very ugly misuse of mu…

    …lti-error.
    
    Previous multi-error implementation could cause very ugly bug of returnig empty multi-error
    that should be treated as success not error by API, but if .Err() is not invoked it will be
    used as non nil error.
    
    There were 9 places where we had this bug in handler due to MultiError lib allowing to do so.
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    
    # Conflicts:
    #	pkg/block/fetcher.go
    #	pkg/compact/compact.go
    #	pkg/compact/compact_test.go
    #	pkg/errutil/multierror.go
    #	pkg/receive/handler.go
    #	pkg/receive/handler_test.go
    bwplotka committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    a32f1ff View commit details
    Browse the repository at this point in the history