Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinforcing errutil and fixed ugly bug which caused empty []error to be treated as error #3836

Merged
merged 1 commit into from
Feb 26, 2021

Commits on Feb 26, 2021

  1. Reinforcing errutil and fixed ugly bug which caused empty []error to …

    …te treated as error,
    
    Previous multi-error implementation could cause very ugly bug of returnig empty multi-error
    that should be treated as success not error by API, but if .Err() is not invoked it will be
    used as non nil error.
    
    Once we merge this, we can do cleaner solution that slighly change nesting behaviour: #3833
    
    There were 9 places where we had this bug in handler due to MultiError lib allowing to do so.
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    bwplotka committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    ef65975 View commit details
    Browse the repository at this point in the history