Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: reduce memory footprint for chunks queries #3937

Merged
merged 12 commits into from
Apr 1, 2021
Merged

store: reduce memory footprint for chunks queries #3937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c2f8d83
Store: add benchmark for quering downsampled data.
krya-kryak Mar 15, 2021
1c5db53
pkg/pool: fix data race
krya-kryak Mar 16, 2021
194d234
pkg/testutil: fix data race
krya-kryak Mar 16, 2021
8c0d7c6
store: reduce allocated memory amount for chunks queries
krya-kryak Mar 16, 2021
6818d9a
pkg/store/bucket: translate variable name from English to US
krya-kryak Mar 16, 2021
38d6b49
store: use slab allocations for chunks
krya-kryak Mar 16, 2021
c8218ec
Update changelog
krya-kryak Mar 16, 2021
07978c9
Revert "pkg/testutil: fix data race"
krya-kryak Mar 17, 2021
e38d349
Apply code review suggestions
krya-kryak Mar 23, 2021
91a52a4
Merge branch 'main' into experiment-reduce-store-mem
krya-kryak Mar 23, 2021
239d243
Merge branch 'main' into experiment-reduce-store-mem
krya-kryak Mar 27, 2021
4b42644
pkg/store: rename variables
krya-kryak Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,13 @@ We use _breaking :warning:_ to mark changes that are not backward compatible (re
- [#3204](https://github.com/thanos-io/thanos/pull/3204) Mixin: Use sidecar's metric timestamp for healthcheck.
- [#3922](https://github.com/thanos-io/thanos/pull/3922) Fix panic in http logging middleware.
- [#3960](https://github.com/thanos-io/thanos/pull/3960) fix deduplication of equal alerts with different labels
- [#3937](https://github.com/thanos-io/thanos/pull/3937) Store: Fix race condition in chunk pool.

### Changed

- [#3948](https://github.com/thanos-io/thanos/pull/3948) Receiver: Adjust `http_request_duration_seconds` buckets for low latency requests.
- [#3856](https://github.com/thanos-io/thanos/pull/3856) Mixin: _breaking :warning:_ Introduce flexible multi-cluster/namespace mode for alerts and dashboards. Removes jobPrefix config option. Removes `namespace` by default.
- [#3937](https://github.com/thanos-io/thanos/pull/3937) Store: Reduce memory usage for range queries.

### Removed

Expand Down
5 changes: 2 additions & 3 deletions pkg/pool/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,12 @@ func (p *BucketedBytes) Put(b *[]byte) {
continue
}
*b = (*b)[:0]
p.mtx.Lock()
krya-kryak marked this conversation as resolved.
Show resolved Hide resolved
defer p.mtx.Unlock()
p.buckets[i].Put(b)
break
}

p.mtx.Lock()
defer p.mtx.Unlock()

// We could assume here that our users will not make the slices larger
// but lets be on the safe side to avoid an underflow of p.usedTotal.
sz := uint64(cap(*b))
Expand Down
Loading