Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Prometheus & Alertmanager #4094

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Upgrade Prometheus & Alertmanager #4094

merged 2 commits into from
Apr 23, 2021

Conversation

pracucci
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

We've an use case in Cortex for which we need to upgrade Prometheus and the Alertmanager. Some breaking changes were introduced in the HTTP client (from prometheus/common) so we need to upgrade it in Thanos too.

What's the sentiment if we do such upgrade in Thanos as well?

Verification

Existing tests

kakkoyun
kakkoyun previously approved these changes Apr 22, 2021
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kakkoyun
Copy link
Member

The Github CI seems broken and failures are not related, in any case I'm going to run the tests locally.

yeya24
yeya24 previously approved these changes Apr 22, 2021
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@kakkoyun kakkoyun merged commit de631e3 into main Apr 23, 2021
@kakkoyun kakkoyun deleted the upgrade-prometheus-common branch April 23, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants