Add tracing spans for rules API #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matsumoto <toshi.matsumoto.3n@gmail.com>
kakkoyun
previously approved these changes
May 5, 2021
yeya24
reviewed
May 5, 2021
yeya24
reviewed
May 5, 2021
Signed-off-by: Matsumoto <toshi.matsumoto.3n@gmail.com>
|
I don't know the best practices either, but... |
bwplotka
previously approved these changes
May 7, 2021
pkg/rules/manager.go
Outdated
Comment on lines
394
to
395
| func (m *Manager) Rules(r *rulespb.RulesRequest, s rulespb.Rules_RulesServer) error { | ||
| var err error |
There was a problem hiding this comment.
Suggested change
| func (m *Manager) Rules(r *rulespb.RulesRequest, s rulespb.Rules_RulesServer) error { | |
| var err error | |
| func (m *Manager) Rules(r *rulespb.RulesRequest, s rulespb.Rules_RulesServer) (err error) { |
We can simplify (:
There was a problem hiding this comment.
I've finished fixing it.
|
Hi @toshi1127, please rebase on main then we can get CI fixed. |
2 tasks
Signed-off-by: Matsumoto <toshi.matsumoto.3n@gmail.com>
kakkoyun
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matsumoto toshi.matsumoto.3n@gmail.com
Changes
Add tracing for federated rules API.
Closes #4131
Verification
make buildmake test-local