Don't add replica labels to exemplar labels, only to its series labels #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yeya24 <yb532204897@gmail.com>
Signed-off-by: yeya24 <yb532204897@gmail.com>
GiedriusS
reviewed
May 13, 2021
pkg/exemplars/exemplars.go
Outdated
| d.Exemplars = dedupExemplars(d.Exemplars, rr.replicaLabels) | ||
| } | ||
|
|
||
| resp.data = dedupExemplarsSeriesLabels(resp.data, rr.replicaLabels) |
There was a problem hiding this comment.
I'm a bit confused. You say:
This pr removes the step of adding replica labels to exemplars. Only adding replica labels to exemplars' series labels.
dedupExemplarsSeriesLabels deduplicates the data using the replica labels and removes those labels. Here now you are now only doing it on the series so series will be without the replica labels, and exemplars - will be with the replica labels. Shouldn't it be the other way around i.e. the deduplication should only happen on the exemplars? 😄
There was a problem hiding this comment.
Sorry, that was my big mistake. Thanks for catching it. I should modify the code from the Prometheus proxy side.
Signed-off-by: yeya24 <yb532204897@gmail.com>
yeya24
force-pushed
the
fix-exemplar-replica-labels
branch
from
da51e79
to
3d508c3
Compare
|
Coin Vote Website https://altcoinvote.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yeya24 yb532204897@gmail.com
Changes
Fixes #4222
This pr removes the step of adding replica labels to exemplars. Only adding replica labels to exemplars' series labels.
Verification