query: Extend metadata service to include target metadata API #4449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipgough
force-pushed
the
issue-3870-1
branch
2 times, most recently
from
fe294de
to
9351ca5
Compare
yeya24
reviewed
Jul 18, 2021
pkg/info/infopb/rpc.proto
Outdated
| message MetricMetadataInfo { | ||
| } | ||
|
|
||
| /// TargetMetadataInfo holds the metadata related to Target Metadata API exposed by the component. | ||
| message TargetMetadataInfo { |
There was a problem hiding this comment.
I am wondering is it better to combine this and MetricMetadataInfo to one MetadataInfo field, in the future?
As they are both belonging to metadatapb, but different services.
There was a problem hiding this comment.
good point, resolved
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
philipgough
force-pushed
the
issue-3870-1
branch
from
9351ca5
to
0cd5429
Compare
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in the review of #4438, this change extends the metadata service to include target metadata api https://prometheus.io/docs/prometheus/latest/querying/api/#querying-target-metadata.
The implementation largely follows the example set by the metric metadata PR in #3686 and in fact piggybacks on the service defined in the metadata proto that was introduced in that feature, since the two metadata APIs are closely related.
This will avoid the need to add an additional flag to define metadata stores. This makes it more convenient but maybe less desirable (we could not take them out of experimental mode independently for example) and I am happy to introduce an additional flag and rpc service if required.
Changes
Extend the metadata rpc service
Verification
None required, updates proto and generated code