ui: Add find overlap block UI #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
reviewed
Jul 28, 2021
squat
reviewed
Aug 4, 2021
squat
reviewed
Aug 4, 2021
|
Nice work @adzshaf , can't wait to see this in action! 💜 |
squat
reviewed
Aug 11, 2021
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
adzshaf
force-pushed
the
add-show-overlapping-block
branch
from
4deba3e
to
03b7362
Compare
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
squat
reviewed
Aug 11, 2021
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
squat
reviewed
Aug 11, 2021
squat
reviewed
Aug 11, 2021
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
|
@squat ready to be merged 👍 |
huyan0
added a commit
to huyan0/thanos
that referenced
this pull request
Aug 12, 2021
Signed-off-by: Yang Hu <yhuz@amazon.com> ui: Add find overlap block UI (thanos-io#4462) * feat(ui): add find overlap blocksui Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * fix(ui): delete comments Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * refactor: refactor find overlap blocks Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * fix: remove unnecessary changes Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * fix: fix search input Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * feat: add query param for find overlapping Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * docs: add changelog Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * docs: move changelog to added Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * fix: change wording Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is part of LFX Mentorship project to improve Block Viewer UI (issue: #3112). We want to add feature so user can find overlapping blocks easily.
Verification
When we haven't enable find overlapping block yet:
Example
enable find overlapping block:Tested on local using
make quickstartcc: @onprem @squat