receive:Tenant's readyS(*ReadyStorage) is not initialized when perform concurrent call getOrLoadTenant #4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
pkg/receive/multitsdb_test.go
Outdated
| for i := 0; i < 3; i++ { | ||
| wg.Add(1) | ||
| go func(index int) { | ||
| func(tt *tenant, err error){ |
There was a problem hiding this comment.
SA4009: argument err is overwritten before first use
(at-me in a reply with help or ignore)
|
Bug trigger conditions:
|
…concurrent getOrLoadTenant Signed-off-by: imneov <grantliu@yunify.com>
… handle prometheus write request Signed-off-by: imneov <grantliu@yunify.com>
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix, ThanosReceive would return a tenant with a uninitialized readyS(*ReadyStorage).
This would trigger a ErrNotReady("TSDB not ready") error. Like #4533.
There are two problems that need to be fixed:
When getOrLoadTenant() is called concurrently, the lock is released prematurely. This will cause the readyS (*ReadyStorage) of the tenant we returned to not be initialized.
thanos/pkg/receive/multitsdb.go
Line 355 in 1964c0c
When we accept Write requests, we cannot use non-block requests, which will also cause the readyS (*ReadyStorage) of the tenant we returned to not be initialized.
This PR use
defer t.mtx.Unlock()released lock to fix getOrLoadTenant()This PR always call getOrLoadTenant in blocking mode.
Fixes #4533
Changes
Verification
Yes, I add a unittest