Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add filter compaction UI #4576

Merged
merged 3 commits into from
Nov 6, 2021
Merged

Conversation

adzshaf
Copy link
Contributor

@adzshaf adzshaf commented Aug 18, 2021

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

This PR is part of LFX Mentorship project to improve Block Viewer UI (issue: #3112). We want to add feature so user can filter blocks by compaction level.

Verification

When we haven't filter anything yet:
image

Filter by compaction level:
image

Tested on local using make quickstart

cc: @onprem @squat

@yeya24
Copy link
Contributor

yeya24 commented Aug 18, 2021

Looks nice! But why the page title is Thanos - Query?

@onprem
Copy link
Member

onprem commented Aug 25, 2021

Looks nice! But why the page title is Thanos - Query?

This is a side effect of how we choose to do development locally. The UI in dev mode just assumes that it is running for Querier.

@yeya24
Copy link
Contributor

yeya24 commented Sep 20, 2021

This looks good. @adzshaf Can you please resolve the conflict?

@yeya24
Copy link
Contributor

yeya24 commented Oct 30, 2021

Any other work needs to be done for this pr? @onprem If not I am happy to resolve the conflicts and get this feature merged.

onprem
onprem previously approved these changes Nov 2, 2021
Copy link
Member

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a non-blocking suggestion. This only needs a rebase and then we can merge this.

pkg/ui/react-app/src/thanos/pages/blocks/SourceView.tsx Outdated Show resolved Hide resolved
adzshaf and others added 3 commits November 6, 2021 12:19
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs CI failure not related. Merging now…

@yeya24 yeya24 merged commit abc5d4c into thanos-io:main Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants