-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
match support for labels api in query frontend #4585
Conversation
Signed-off-by: Sandeep Raveesh <crsandy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the awesome work! Only one small nit.
Signed-off-by: Sandeep Raveesh <crsandy@gmail.com>
Signed-off-by: Sandeep Raveesh <crsandy@gmail.com>
@GiedriusS I am looking at the E2E failure.
Is this error related to #4535? |
That's interesting, I'll have to take a look |
Where did you find this? I have checked the e2e tests on this PR and they had timed out. Restarting helped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution.
Signed-off-by: Sandeep Raveesh crsandy@gmail.com
Fixes #4580
Changes
This PR adds the support for match[] parameter for labels api in query frontend
Verification
I added the required tests to verify this.