e2e tests: Move to efficientgo/e2e
#4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjusts services to use e2e - Simplifies some func signatures, remove redundant funcs etc. - Adds service for reverse proxy (instead of using one on host) - Adds service for Minio (a workaround, see issue in the func comment) Signed-off-by: Matej Gera <matejgera@gmail.com>
- Mechanical replacement / adjustments to new services, package imports etc. Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
matej-g
changed the title
efficientgo/e2eefficientgo/e2e
Signed-off-by: Matej Gera <matejgera@gmail.com>
|
@matej-g Is this ready for review now 😄 |
Hey @yeya24, please see my comment in #4579 (comment) and the subsequent comment. The summary - this is open to review / feedback, but I did not wanted to undraft this until I fully understand the issue and to be sure the tests will not be flaking. |
- Remove manually building hostname with netName - Use InternalEndpoint instead - Take advantage of future runnable to get hostname addresses for configs Signed-off-by: Matej Gera <matejgera@gmail.com>
yeya24
approved these changes
Sep 28, 2021
bwplotka
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR moves Thanos e2e test suite to https://github.com/efficientgo/e2e, in line with the aims set out in #3832 (comment) and #4579
This is a relatively large changeset, but keep in mind most of this is 'mechanical' replacement. Most crucial changes are done to the
e2ethanospackage, rest of the tests then follow these changes. Other notable changes:172.17.0.1on every setup)StartAndWaitReadycompletes efficientgo/e2e#11 (should be removed after this is resolved)Verification
Running E2E tests locally.